A new inspection was created.

fixes #15702

hmmm .. behavioral change with no adoption of unit tests? This is fishy - please investigate - THX

👎 until impact/unit testing solved - THX

For what is is worth I have applied this change in the lab and it works as expected (files and folders no longer disappear on rename)...hope this is helpful!!!

👎 until impact/unit testing solved - THX

@butonic @icewind1991 Can you have a look at this please

Patch applied in my owncloud installation using public openstack swift service as storage and now it works. I hope to see this branch merged as soon as possible.

superseded by #19414 which contains this fix as well as a testsuite

Reopening because the testsuite is now in place.

@DeepDiver1975 please enable objectstore tests for this one

pinging @icewind1991 and @MorrisJobke for review now that the testsuite is in place.

@DeepDiver1975 please enable objectstore tests for this one

done

@DeepDiver1975 @butonic Running since 3hs: https://ci.owncloud.org/job/core-ci-linux-swift_primary_storage_tests/database=sqlite,label=SLAVE/29/console

Change looks good 👍

TODO:

• ci is hanging for what ever reason
• I really insist on a unit test which covers the changed behavior

@icewind1991 keep it coming! This is awesome!

SQLite seems to fail:

11:49:02 1) Test_Files_Sharing_Watcher::testFolderSizePropagationToOwnerStorage
11:49:02 Failed asserting that true is false.
11:49:02 
11:49:02 /ssd/jenkins/workspace/server-master-linux-php7-ci/database/sqlite/label/SLAVE/apps/files_sharing/tests/watcher.php:123
11:49:02 
11:49:02 2) Test_Files_Sharing_Watcher::testSubFolderSizePropagationToOwnerStorage
11:49:02 Failed asserting that true is false.
11:49:02 
11:49:02 /ssd/jenkins/workspace/server-master-linux-php7-ci/database/sqlite/label/SLAVE/apps/files_sharing/tests/watcher.php:153

rebased ...

Nice job @icewind1991 🚀

I'm actually setting the milestone to 9.0 since this pr is against master.

@karlitschek we need to backport this to fix serious issues in 8.2.1

agreed. please backport

The unit tests crash on a btrfs docker host ...

Turning ON incompat feature 'mixed-bg': mixed data and metadata block groups
Turning ON incompat feature 'extref': increased hardlink limit per file to 65536
SMALL VOLUME: forcing mixed metadata/data groups

WARNING! - Btrfs v3.12 IS EXPERIMENTAL
WARNING! - see http://btrfs.wiki.kernel.org before using

Created a data/metadata chunk of size 8388608
fs created label (null) on /tmp/osddata
        nodesize 4096 leafsize 4096 sectorsize 4096 size 300.00MiB
Btrfs v3.12
mounting via loopback
mount: Could not find any loop device. Maybe this kernel does not know
       about the loop device? (If so, recompile or `modprobe loop'.)

@butonic Is there a way to fix this easily? Otherwise I'm fine with this but can't test it.

But code wise this looks good 👍

@MorrisJobke hm did you run autotest or just start the container? It needs to run in privileged mode so that loopback devices can be used.

Another solution would be to autodetect btrfs and then not do the whole loobpack device magic as docker can then use the native snapshots to do the fs layering. You could try ripping the loopback stuff from https://github.com/owncloud/core/blob/master/tests/objectstore/entrypoint.sh to see if that helps.

Another thing is that the test currently uses a 300MB storage ... which is enough to run the test suite but might not be enough to test large file uploads.

@MorrisJobke hm did you run autotest or just start the container?

I did:

$ PRIMARY_STORAGE_CONFIG=swift ./autotest.sh sqlite

I will try to add a condition for btrfs ... but I think this can be hard to detect 🙈

I will try to add a condition for btrfs ... but I think this can be hard to detect 🙈

I see no need in spending more time into this - @butonic already invested days in finally funding a running solution for our ci system - this is enough from my pov at the moment.

The unit tests crash on a btrfs docker host ...

Run sudo modprobe loop beforehand

Run sudo modprobe loop beforehand

Already solved: #19864

👍 Awesome work icewind! Thanks for taking a look at this!

@butonic can you create the backport? Thanks

will create PRs for 8.2 and then try 8.1

will create PRs for 8.2 and then try 8.1

up to now we did only talk about 8.2 - what is the need to have this in 8.1?

probably none with the next enterprise edition being based on 8.2. Let's see who starts screaming first...